RFC 0026: Host chain discovery and name resolution - #354
Merged
Conversation
Add the RFC document plus its protocol surface: chain.getSupportedChains (wire id 166) enumerates the chains a host serves as (name, network, genesisHash) descriptors, and chain.resolveChain (168) maps a (name, network) pair to its genesis hash or NotFound. Both trait methods are stubs returning unavailable, so products stop hard-coding genesis hashes once hosts implement the backing syscall in a follow-up.
valentinfernandez1
force-pushed
the
rfc-0026-supported-chains
branch
from
August 6, 2026 17:21
c9fecf0 to
c94a07b
Compare
pgherveou
reviewed
Aug 6, 2026
pgherveou
left a comment
pgherveou
left a comment
Collaborator
There was a problem hiding this comment.
I would add a single method that takes all the identifiant we want to resolve. It should be enough.
Also as you are adding this you can fix all the hard coded genesis hash from the other comment api tests
Contributor
|
I think more ergonomic and focused API would be enum ChainIdentifier {
relay,
people,
/// ...
}
struct ChainInfo {
genesisHash: [u8; 32],
name: String,
/// ...
}
fn getChainInfo(ChainIdentifier): ChainInfo;User don't need a full mapping every time where later he need to pick specific chain from list |
johnthecat
reviewed
Aug 7, 2026
Collaborator
Author
|
Thanks for the feedback, it's been implemented so feel free to review again |
johnthecat
requested changes
Aug 7, 2026
johnthecat
reviewed
Aug 7, 2026
pgherveou
approved these changes
Aug 7, 2026
valentinfernandez1
enabled auto-merge
August 7, 2026 13:54
filvecchiato
approved these changes
Aug 7, 2026
johnthecat
approved these changes
Aug 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 8, 2026
TarikGul
added a commit
that referenced
this pull request
Aug 11, 2026
Brings the branch up to `aa878d1f`, so the PR is mergeable again. One conflict, in `host_core.rs`, between two additions to the same region: this branch's native-only `impl SigningHostRuntime` carrying the renewal entry points, and `ConnectionAdapters` from the Chat integration (#326). Both are kept; neither references the other. The rest of main merged cleanly, including the FFI type rename (#345), Extrinsic V5 signing (#333), and RFC-0026 chain discovery (#354, #358). Verified on the merge result: `cargo +nightly fmt --check`, `clippy --workspace --all-targets --all-features -D warnings`, 683 workspace tests, and `cargo check --target wasm32-unknown-unknown -p truapi-server`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #352.